Messages in this thread | | | Subject | Re: [PATCH 1/3] Input: add STMicroelectronics FingerTip touchscreen driver | From | Javier Martinez Canillas <> | Date | Tue, 17 Jan 2017 11:32:49 -0300 |
| |
Hello Andi,
On 01/17/2017 10:54 AM, Andi Shyti wrote: > Add binding for the STMicroelectronics FingerTip (stmfts) > touchscreen driver. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > ---
The binding looks good to me, I've just a minor nit below.
[snip]
> + > +i2c@00000000 { > + > + /* ... */ > + > + stmfts@49 {
The ePAPR document says:
The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model.
So I think this should be touchscreen@49 instead.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
| |