Messages in this thread | | | From | Kalle Valo <> | Subject | Re: linux-next: build warning after merge of the wireless-drivers-next tree | Date | Tue, 17 Jan 2017 13:49:31 +0200 |
| |
Kalle Valo <kvalo@codeaurora.org> writes:
> Stephen Rothwell <sfr@canb.auug.org.au> writes: > >> Hi all, >> >> After merging the wireless-drivers-next tree, today's linux-next build >> (x86_64 allmodconfig) produced this warning: >> >> drivers/net/wireless/marvell/mwifiex/pcie.c: In function 'mwifiex_pcie_remove': >> drivers/net/wireless/marvell/mwifiex/pcie.c:303:5: warning: 'fw_status' may be used uninitialized in this function [-Wmaybe-uninitialized] >> if (fw_status == FIRMWARE_READY_PCIE && !adapter->mfg_mode) { >> ^ >> >> Introduced by commit >> >> 045f0c1b5e26 ("mwifiex: get rid of global user_rmmod flag") >> >> This is not a false positive since "reg" could be NULL just above >> (otherwise it would be tested for). > > Thanks, I noticed this myself yesterday (after I had applied the patch) > and I have asked Marvell to send a fix.
I missed that Arnd had already sent a fix, I'll apply that one:
mwifiex: fix uninitialized variable access in pcie_remove
https://patchwork.kernel.org/patch/9515899/
-- Kalle Valo
| |