Messages in this thread | | | Date | Mon, 16 Jan 2017 15:46:14 +0900 | From | Chanwoo Choi <> | Subject | Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table |
| |
Hi,
I think that this patch better to squash with patch3. After applying the patch3, this driver doesn't use the max77686_i2c_id table.
On 2017년 01월 13일 22:34, Javier Martinez Canillas wrote: > The driver is only used in DT platforms so there's no need to > have an i2c_device_id table. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > Acked-by: Laxman Dewangan <ldewangan@nvidia.com> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > Tested-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > Changes in v2: > - Add Laxman's Acked-by tag to patch 4/4. > - Add Krzysztof's Reviewed-by and Tested-by tags to patch 4/4. > > drivers/mfd/max77686.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c > index 896c1bf85acc..b0e8e13c0049 100644 > --- a/drivers/mfd/max77686.c > +++ b/drivers/mfd/max77686.c > @@ -241,13 +241,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c) > return 0; > } > > -static const struct i2c_device_id max77686_i2c_id[] = { > - { "max77686", TYPE_MAX77686 }, > - { "max77802", TYPE_MAX77802 }, > - { } > -}; > -MODULE_DEVICE_TABLE(i2c, max77686_i2c_id); > - > #ifdef CONFIG_PM_SLEEP > static int max77686_suspend(struct device *dev) > { > @@ -294,7 +287,6 @@ static struct i2c_driver max77686_i2c_driver = { > .of_match_table = of_match_ptr(max77686_pmic_dt_match), > }, > .probe_new = max77686_i2c_probe, > - .id_table = max77686_i2c_id, > }; > > module_i2c_driver(max77686_i2c_driver); >
-- Best Regards, Chanwoo Choi S/W Center, Samsung Electronics
| |