Messages in this thread | | | Subject | Re: [PATCH] checkpatch: update $logFunctions | From | Joe Perches <> | Date | Sun, 15 Jan 2017 19:14:10 -0800 |
| |
On Mon, 2017-01-16 at 10:57 +0800, Miles Chen wrote: > On Fri, 2017-01-13 at 00:14 -0800, Joe Perches wrote: > > On Fri, 2017-01-13 at 15:38 +0800, miles.chen@mediatek.com wrote: > > > From: Miles Chen <miles.chen@mediatek.com> > > > > > > Currently checkpatch.pl does not recognize printk_deferred* functions as > > > log functions and complains about the line length of printk_deferred* > > > functoins. Add printk_deferred* to logFunctions to fix it. > > > > Hi Miles. > > > > Good idea, perhaps less good an implementation though. > > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > > > [] > > > @@ -425,7 +425,7 @@ our $zero_initializer = qr{(?:(?:0[xX])?0+$Int_type?|NULL|false)\b}; > > > > > > our $logFunctions = qr{(?x: > > > printk(?:_ratelimited|_once|)| > > > - (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)| > > > + (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN|deferred)(?:_ratelimited|_once|)| > > > > This should be a change on the line above like > > > > printk(?:_ratelimited|_once|_deferred|_deferred_once|)|
> Thanks for your advice, I'll modify my patch and submit it again.
Hello again Miles.
Actually, because perl matches the shortest match first, the deferred_once should be before the deferred above so deferred_once matches properly too. ie:
printk(?:_ratelimited|_once|_deferred_once|_deferred|)|
> > Or perhaps changing both lines if there are to be > > macros/functions like pr_<level>_deferred_once someday. > > > > printk(?:_ratelimited|_once|_deferred|_deferred_once|)| > > (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|_deferred|deferred_once|)|
Here too for both lines if you submit this one.
| |