Messages in this thread | | | Date | Sun, 15 Jan 2017 15:39:30 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol |
| |
On Sat, Jan 14, 2017 at 01:09:57PM +0100, Arnd Bergmann wrote: > On Jan 13, 2017 10:42 PM, "Dmitry Torokhov" <dmitry.torokhov@gmail.com> wrote: > > On Fri, Jan 13, 2017 at 10:34:32PM +0100, Arnd Bergmann wrote: > > > config RMI4_F03_SERIO > > > tristate > > > depends on RMI4_CORE > > > depends on RMI4_F03 > > > default RMI4_CORE > > > select SERIO > > > > > > As that avoids the 'depends on SERIO=y || RMI4_CORE=SERIO' statement that > > > is different from the other SERIO users, it keeps it all in one place, > > > and it doesn't > > > prevent you from seeing the RMI4_F03 symbol when SERIO=m. > > Hmm, if this works and resilient with user changing symbols after > > they've been auto-selected then I like it. How can we run it through > > multitude of randconfigs? > > I've successfully run it over night on a few hundred randconfig builds without > problems now, so I'm pretty confident it works. > > The hidden option will ensure the configuration is always valid even when > the user changes it, the only thing that can be unexpected is the same as > every 'select': when you enable this option, SERIO will get turned on, and > when you disable it again after leaving 'menuconfig', it stays on.
Great. Could you please send me real patch and I'll get it to Linus?
Thanks.
-- Dmitry
| |