Messages in this thread | | | Subject | Re: [PATCH] iio: magnetometer: ak8974: remove redundant zero timeout check | From | Jonathan Cameron <> | Date | Sat, 14 Jan 2017 13:10:43 +0000 |
| |
On 11/01/17 23:11, Linus Walleij wrote: > On Wed, Jan 11, 2017 at 6:49 PM, Colin King <colin.king@canonical.com> wrote: > >> From: Colin Ian King <colin.king@canonical.com> >> >> At the end of the delay loop timeout will always be zero >> and hence the check for !timeout will always be true. Remove >> the redundant check and the redundant return 0 at the end of >> the function. >> >> Fixes CoverityScan CID#1357168 ("Logically dead code") >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> > > Clever Coverity scan. > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.
Thanks,
Jonathan > Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
| |