lkml.org 
[lkml]   [2017]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 08/17] spi/ppc4xx: Use kcalloc() in spi_ppc4xx_of_probe()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 13 Jan 2017 14:30:43 +0100

    * A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus reuse the corresponding function "kcalloc".

    This issue was detected by using the Coccinelle software.

    * Replace the specification of a data type by a pointer dereference
    to make the corresponding size determination a bit safer according to
    the Linux coding style convention.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/spi/spi-ppc4xx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/spi/spi-ppc4xx.c b/drivers/spi/spi-ppc4xx.c
    index dd3d0a218d8b..e0c39734d6ef 100644
    --- a/drivers/spi/spi-ppc4xx.c
    +++ b/drivers/spi/spi-ppc4xx.c
    @@ -411,7 +411,7 @@ static int spi_ppc4xx_of_probe(struct platform_device *op)
    if (num_gpios > 0) {
    int i;

    - hw->gpios = kzalloc(sizeof(int) * num_gpios, GFP_KERNEL);
    + hw->gpios = kcalloc(num_gpios, sizeof(*hw->gpios), GFP_KERNEL);
    if (!hw->gpios) {
    ret = -ENOMEM;
    goto free_master;
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-01-13 18:18    [W:4.170 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site