lkml.org 
[lkml]   [2017]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cxgb4: Remove redundant memset before memcpy
On 2017-01-13 at 10:52:49 +0100, Shyam Saini <mayhs11saini@gmail.com> wrote:
> The region set by the call to memset, immediately overwritten by the
> subsequent call to memcpy and thus makes the memset redundant
>
> Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
> ---
> drivers/net/ethernet/chelsio/cxgb4/sched.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c b/drivers/net/ethernet/chelsio/cxgb4/sched.c
> index cbd68a8..5725693 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/sched.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c
> @@ -398,7 +398,6 @@ static struct sched_class *t4_sched_class_lookup(struct port_info *pi,
> struct ch_sched_params tp;
>
> memset(&info, 0, sizeof(info));

This memset is also redundant because info is memcpy()'ed to before
being used in the loop (and it isn't used outside of the loop).

> - memset(&tp, 0, sizeof(tp));
>
> memcpy(&tp, p, sizeof(tp));
> /* Don't try to match class parameter */
> @@ -409,7 +408,6 @@ static struct sched_class *t4_sched_class_lookup(struct port_info *pi,
> if (e->state == SCHED_STATE_UNUSED)
> continue;
>
> - memset(&info, 0, sizeof(info));
> memcpy(&info, &e->info, sizeof(info));
> /* Don't try to match class parameter */
> info.u.params.class = SCHED_CLS_NONE;
> @@ -458,7 +456,6 @@ static struct sched_class *t4_sched_class_alloc(struct port_info *pi,
> if (!e)
> goto out;
>
> - memset(&np, 0, sizeof(np));
> memcpy(&np, p, sizeof(np));
> np.u.params.class = e->idx;
>
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2017-01-13 16:58    [W:0.052 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site