Messages in this thread | | | Date | Fri, 13 Jan 2017 16:55:53 +0100 | From | Alexandre Belloni <> | Subject | Re: [PATCH 3/3] rtc: stm32: use 32-bit cast for BIT() macro |
| |
On 13/01/2017 at 15:52:29 +0000, Russell King - ARM Linux wrote : > On Fri, Jan 13, 2017 at 04:32:53PM +0100, Arnd Bergmann wrote: > > -#define PWR_CR_DBP BIT(8) > > +#define PWR_CR_DBP (u32)BIT(8) > > Shouldn't that have parens around it as it's no longer a simple expression. >
Yes, at least checkpatch complains about it.
-- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
| |