Messages in this thread | | | Subject | Re: [PATCH 8/9] serdev: add a tty port controller driver | From | Andy Shevchenko <> | Date | Fri, 13 Jan 2017 17:55:07 +0200 |
| |
On Fri, 2017-01-13 at 09:28 -0600, Rob Herring wrote: > On Fri, Jan 13, 2017 at 9:04 AM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, 2017-01-12 at 10:01 -0600, Rob Herring wrote: > > > On Sat, Jan 7, 2017 at 8:11 AM, Andy Shevchenko > > > <andriy.shevchenko@linux.intel.com> wrote: > > > > On Fri, 2017-01-06 at 10:26 -0600, Rob Herring wrote:
> > > Yes, otherwise the bus can be built as a module and this driver > > > can > > > still be enabled breaking the build. I could drop supporting > > > building > > > the bus as a module because as long as this is the only controller > > > driver, it all has to be built-in. > > > > Would > > > > if SERIAL_DEV_BUS=y > > > > work for you? > > Yes, until we add a driver that doesn't have to be built-in. What > about "depends on SERIAL_DEV_BUS != m"? That would be a bit more clear > what the reason is.
Ah, good point.
Yes, it would also work. My concern was here is not add confusing 'depend on MENU_OPTION'.
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |