[lkml]   [2017]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] pinctrl: core: Fix regression caused by delayed work for hogs
Hi Tony,

On Wed, Jan 11, 2017 at 11:13 PM, Tony Lindgren <> wrote:
> Commit df61b366af26 ("pinctrl: core: Use delayed work for hogs") caused a
> regression at least with sh-pfc that is also a GPIO controller as
> noted by Geert Uytterhoeven <>.
> As the original pinctrl_register() has issues calling pin controller
> driver functions early before the controller has finished registering,
> we can't just revert commit df61b366af26. That would break the drivers
> So let's fix the issue with the following steps as a single patch:
> 1. Revert the late_init parts of commit df61b366af26.
> The late_init clearly won't work and we have to just give up
> on fixing pinctrl_register() for GENERIC_PINCTRL_GROUPS and
> 2. Split pinctrl_register() into two parts
> By splitting pinctrl_register() into pinctrl_init_controller()
> and pinctrl_create_and_start() we have better control over when
> it's safe to call pinctrl_create().
> 3. Introduce a new pinctrl_register_and_init() function
> As suggested by Linus Walleij <>, we
> can just introduce a new function for the controllers that need
> pinctrl_create() called later.
> 4. Convert the four known problem cases to use new function
> Let's convert pinctrl-imx, pinctrl-single, sh-pfc and ti-iodelay
> to use the new function to fix the issues. The rest of the drivers
> can be converted later. Let's also update Documentation/pinctrl.txt
> accordingly because of the known issues with pinctrl_register().
> Fixes: df61b366af26 ("pinctrl: core: Use delayed work for hogs")
> Reported-by: Geert Uytterhoeven <>
> Cc: Gary Bisson <>
> Signed-off-by: Tony Lindgren <>

Thanks, this fixes r8a7740/armadillo.

Tested-by: Geert Uytterhoeven <>



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

 \ /
  Last update: 2017-01-12 09:44    [W:0.040 / U:1.944 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site