lkml.org 
[lkml]   [2017]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/1] x86/kernel: Update bug_at() head message

* Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> First of all, %*ph specifier allows to dump data in hex format using the
> pointer to a buffer. This is suitable to use here.
>
> Besides that Thomas suggested to move it to critical level and replace __FILE__
> by explicit mention of "jumplabel".
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> arch/x86/kernel/jump_label.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
> index fc25f698d792..32f126e726f5 100644
> --- a/arch/x86/kernel/jump_label.c
> +++ b/arch/x86/kernel/jump_label.c
> @@ -32,8 +32,7 @@ static void bug_at(unsigned char *ip, int line)
> * Something went wrong. Crash the box, as something could be
> * corrupting the kernel.
> */
> - pr_warning("Unexpected op at %pS [%p] (%02x %02x %02x %02x %02x) %s:%d\n",
> - ip, ip, ip[0], ip[1], ip[2], ip[3], ip[4], __FILE__, line);
> + pr_crit("jumplabel: Unexpected op at %pS [%p] (%5ph) %d\n", ip, ip, ip, line);
> BUG();

What is 'jumplabel'? Nobody calls it that in the kernel - everyone calls it
'jump_label' ...

(Fixed that in patch, no need to resend.)

Thanks,

Ingo

\
 
 \ /
  Last update: 2017-01-12 09:43    [W:0.070 / U:3.700 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site