| From | Bart Van Assche <> | Subject | Re: [PATCH 07/10] blk-mq: abstract out helpers for allocating/freeing tag maps | Date | Thu, 12 Jan 2017 21:29:00 +0000 |
| |
On Wed, 2017-01-11 at 14:40 -0700, Jens Axboe wrote: > @@ -2392,12 +2425,12 @@ int blk_mq_alloc_tag_set(struct blk_mq_tag_set *set) > if (set->nr_hw_queues > nr_cpu_ids) > set->nr_hw_queues = nr_cpu_ids; > > + ret = -ENOMEM; > set->tags = kzalloc_node(nr_cpu_ids * sizeof(struct blk_mq_tags *), > GFP_KERNEL, set->numa_node); > if (!set->tags) > return -ENOMEM; > > - ret = -ENOMEM; > set->mq_map = kzalloc_node(sizeof(*set->mq_map) * nr_cpu_ids, > GFP_KERNEL, set->numa_node); > if (!set->mq_map)
Not that it matters to me, but this change probably isn't needed?
Anyway:
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
|