[lkml]   [2017]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 8/8] crypto/testmgr: Allocate only the required output size for hash tests
On Wed, Jan 11, 2017 at 11:47 PM, Herbert Xu
<> wrote:
> Andy Lutomirski <> wrote:
>> There are some hashes (e.g. sha224) that have some internal trickery
>> to make sure that only the correct number of output bytes are
>> generated. If something goes wrong, they could potentially overrun
>> the output buffer.
>> Make the test more robust by allocating only enough space for the
>> correct output size so that memory debugging will catch the error if
>> the output is overrun.
>> Tested by intentionally breaking sha224 to output all 256
>> internally-generated bits while running on KASAN.
>> Cc: Ard Biesheuvel <>
>> Cc: Herbert Xu <>
>> Signed-off-by: Andy Lutomirski <>
> This patch doesn't seem to depend on anything else in the series.
> Do you want me to take it separately?

Yes, please. Its only relation to the rest of the series is that I
wanted to make sure that I didn't mess up sha224's finalization code.


 \ /
  Last update: 2017-01-12 08:53    [W:0.093 / U:0.972 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site