lkml.org 
[lkml]   [2017]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] reset: constify reset_control_ops structures
From
Date
Am Montag, den 09.01.2017, 22:23 +0530 schrieb Bhumika Goyal:
> Declare reset_control_ops structures as const as they are only stored
> in the ops field of a reset_controller_dev structure. This field is of
> type const struct reset_control_ops *, so reset_control_ops structures
> having this property can be declared as const.
> Done using Coccinelle:
>
> @r1 disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct reset_control_ops i@p={...};
>
> @ok1@
> identifier r1.i;
> position p;
> struct ti_syscon_reset_data data;
> @@
> data.rcdev.ops=&i@p;
>
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct reset_control_ops i;
>
> File size before: drivers/reset/reset-ti-syscon.o
> text data bss dec hex filename
> 1329 240 0 1569 621 drivers/reset/reset-ti-syscon.o
>
> File size after: drivers/reset/reset-ti-syscon.o
> text data bss dec hex filename
> 1377 192 0 1569 621 drivers/reset/reset-ti-syscon.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Applied, thank you.

regards
Philipp

\
 
 \ /
  Last update: 2017-01-12 11:56    [W:0.034 / U:8.464 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site