lkml.org 
[lkml]   [2017]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] capability: export has_capability
On Wed, Jan 11, 2017 at 01:47:01PM -0500, Alex Williamson wrote:
> On Thu, 22 Dec 2016 00:10:15 +0800
> Jike Song <jike.song@intel.com> wrote:
>
> > has_capability() is sometimes needed by modules to test capability
> > for specified task other than current, so export it.
> >
> > Cc: Alex Williamson <alex.williamson@redhat.com>
> > Cc: Kirti Wankhede <kwankhede@nvidia.com>
> > Signed-off-by: Jike Song <jike.song@intel.com>
> > ---
> > kernel/capability.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/kernel/capability.c b/kernel/capability.c
> > index 4984e1f..e2e198c 100644
> > --- a/kernel/capability.c
> > +++ b/kernel/capability.c
> > @@ -318,6 +318,7 @@ bool has_capability(struct task_struct *t, int cap)
> > {
> > return has_ns_capability(t, &init_user_ns, cap);
> > }
> > +EXPORT_SYMBOL(has_capability);
> >
> > /**
> > * has_ns_capability_noaudit - Does a task have a capability (unaudited)
>
> Are we using EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL here to match the other
> exports in this file? We could use _GPL to match the expected caller
> of this.
>
>
> Serge,
>
> Do you have any comments on this patch? I'd be happy to pull it
> through the vfio tree with an appropriate Ack. Thanks,

Sure, thanks, looks good to me.

Acked-by: Serge Hallyn <serge@hallyn.com>

\
 
 \ /
  Last update: 2017-01-12 07:46    [W:0.077 / U:2.440 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site