lkml.org 
[lkml]   [2017]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i2c: piix4: Avoid race conditions with IMC

> > > + unsigned short piix4_smba = adapdata->smba;
> > > u8 smba_en_lo;
> > > u8 port;
> > > int retval;
> > > + int timeout = 0;
> > > + int smbslvcnt;
> >
> > Keep them just after your another added variable.
>
> FWIW, I don't think this makes sense as a general rule. I'd rather have
> the variables in an order which makes sense (for human readers or for
> stack size optimization - unless gcc does it for us?), rather than
> always adding at the same place. Is there a rationale for doing that? I
> don't think shrinking the patch size is good enough a reason.

Not really. Some say "Reorder to save bytes", some say "reorder to
utilize cache lines most". Unless I get some numbers showing the desired
effect, I go for "most readable" approach which is subjective, of
course. I'd be totally fine with the above.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-01-12 11:01    [W:0.111 / U:3.044 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site