lkml.org 
[lkml]   [2017]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user
    I looked at the get_user part of the original script.  It looks like most
    of the complexity is to deal with the possibility of the src location
    being expressed in two different ways between the two calls. Even if this
    happens in practice only for get_user, it would seem that it could happen
    for copy_from_user as well. So I think we could just throw both get_user
    and copy_from_user into the same rule?

    I'm also not sure to understand why there are cases for things like

    get_user(exp1, src->f1)
    ...
    get_user(exp2,src)

    Can this happen? The types seem wrong.

    Likewise, I see the need to take into account a second argument of src++,
    but not the need to take into account a second argument of src+4. Either
    there is src+4 in both calls or the addresses involved are just different.

    Perhaps I'm missing something, though.

    julia

    \
     
     \ /
      Last update: 2017-01-11 07:13    [W:0.019 / U:0.976 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site