lkml.org 
[lkml]   [2017]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Dell XPS13 does not suspend with Linux 4.10-rc3
From
Date
On 01/11/17 10:36, Greg Kroah-Hartman wrote:
> On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote:

>> On 01/10/17 23:24, Jan Niehusmann wrote:
>>> On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
>>>> And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
>>>> FW"
>>>
>>> Indeed, just disabling the FIXUP implemented by that commit fixes
>>> suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
>>>
>>> (For the addressees newly added to cc, it seems like the mentioned
>>> commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
>>>
>>> --- a/drivers/misc/mei/bus-fixup.c
>>> +++ b/drivers/misc/mei/bus-fixup.c
>>> @@ -406,3 +406,3 @@ static struct mei_fixup {
>>> MEI_FIXUP(MEI_UUID_WD, mei_wd),
>>> - MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
>>> +// MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
>>> };
>>>
>>>
>>> I don't know what this may break, as the description of 7279b23 just
>>> says:
>>> "This workaround was added to support other broken OS and we need to
>>> follow here."
>>>
>>> Unless there is a better justification, I think the commit should be
>>> reverted, for now.
>>
>> Somebody else already created the bug 192051 in the Linux Kernel Bug Tracker
>> [1].
>
> There's a fix for this in my tree to go to Linus for 4.10-rc4.

Yes, Tomas referenced it in the bug report. I test it on the Dell XPS13
(9360) now.

I would have liked if it mentioned suspend issues, and the known broken
devices in the commit message. That way, I would have found the commit
more easily.


Kind regards,

Paul

\
 
 \ /
  Last update: 2017-01-11 10:49    [W:0.072 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site