Messages in this thread | | | Date | Tue, 10 Jan 2017 11:37:36 -0800 | From | Davidlohr Bueso <> | Subject | Re: [PATCH 0/2] sched: Introduce rcuwait |
| |
On Tue, 10 Jan 2017, Oleg Nesterov wrote:
>Well, speaking of naming, rcuwait_trywake() doesn't look good to me, >rcuwait_wake_up() looks better, "try" is misleading imo. But this is >cosmetic/subjective too.
I actually added the 'try' on second thought -- in that for the particular pcpu-rwsem user, obviously most of the time the wakeup will not actually occur. But yeah, I'd have no problem just naming it rcuwait_wake_up().
>Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Thanks!
| |