Messages in this thread | | | Subject | Re: [PATCH] gpio: pca953x: Add optional reset gpio control | From | Steve Longerbeam <> | Date | Tue, 10 Jan 2017 10:57:18 -0800 |
| |
On 01/03/2017 03:37 PM, Andy Shevchenko wrote: > On Mon, Jan 2, 2017 at 11:07 PM, Steve Longerbeam <slongerbeam@gmail.com> wrote: >> Add optional reset-gpios pin control. If present, de-assert the >> specified reset gpio pin to bring the chip out of reset. >> --- a/drivers/gpio/gpio-pca953x.c >> +++ b/drivers/gpio/gpio-pca953x.c >> @@ -22,6 +22,7 @@ >> #include <linux/of_platform.h> >> #include <linux/acpi.h> >> #include <linux/regulator/consumer.h> >> +#include <linux/gpio/consumer.h> > Please, try to put it somehow alphabetically ordered (yes, I see it's > not in general, but try to squeeze it into longest part which is > ordered).
done.
> >> #define PCA953X_INPUT 0 >> #define PCA953X_OUTPUT 1 >> @@ -754,8 +755,18 @@ static int pca953x_probe(struct i2c_client *client, >> invert = pdata->invert; >> chip->names = pdata->names; >> } else { >> + struct gpio_desc *reset_gpio; >> + >> chip->gpio_start = -1; >> irq_base = 0; >> + >> + /* see if we need to de-assert a reset pin */ > see -> See
done.
Steve
| |