lkml.org 
[lkml]   [2017]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 036/101] USB: serial: garmin_gps: fix memory leak on failed URB submit
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit c4ac4496e835b78a45dfbf74f6173932217e4116 upstream.

    Make sure to free the URB transfer buffer in case submission fails (e.g.
    due to a disconnect).

    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/serial/garmin_gps.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/usb/serial/garmin_gps.c
    +++ b/drivers/usb/serial/garmin_gps.c
    @@ -1044,6 +1044,7 @@ static int garmin_write_bulk(struct usb_
    "%s - usb_submit_urb(write bulk) failed with status = %d\n",
    __func__, status);
    count = status;
    + kfree(buffer);
    }

    /* we are done with this urb, so let the host driver

    \
     
     \ /
      Last update: 2017-01-10 16:17    [W:4.332 / U:0.832 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site