lkml.org 
[lkml]   [2017]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 072/101] clk: clk-wm831x: fix a logic error
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Pan Bian <bianpan2016@163.com>

    commit 20979202ee6e4c68dab7bcf408787225a656d18e upstream.

    Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function
    wm831x_clkout_is_prepared() returns "true" when it fails to read
    CLOCK_CONTROL_1. "true" means the device is already prepared. So
    return "true" on the read failure seems improper.

    Signed-off-by: Pan Bian <bianpan2016@163.com>
    Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
    Fixes: f05259a6ffa4 ("clk: wm831x: Add initial WM831x clock driver")
    Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/clk/clk-wm831x.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/clk/clk-wm831x.c
    +++ b/drivers/clk/clk-wm831x.c
    @@ -247,7 +247,7 @@ static int wm831x_clkout_is_prepared(str
    if (ret < 0) {
    dev_err(wm831x->dev, "Unable to read CLOCK_CONTROL_1: %d\n",
    ret);
    - return true;
    + return false;
    }

    return (ret & WM831X_CLKOUT_ENA) != 0;

    \
     
     \ /
      Last update: 2017-01-10 14:41    [W:2.927 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site