lkml.org 
[lkml]   [2017]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: most: hdm-usb: Fix sparse warning cast to restricted __le16
On Mon, 9 Jan 2017 21:25:56 -0600
Eric Salem <ericsalem@gmail.com> wrote:

> Fixed the following sparse warning:
>
> drivers/staging/most/hdm-usb/hdm_usb.c:158:16: warning:
> cast to restricted __le16
>
> by correcting the variable's type (also updated sizeof).
>
> Signed-off-by: Eric Salem <ericsalem@gmail.com>

Acked-by: Christian Gromm <christian.gromm@microchip.com>

> ---
> drivers/staging/most/hdm-usb/hdm_usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c
> index d6db0bd..01e3a31 100644
> --- a/drivers/staging/most/hdm-usb/hdm_usb.c
> +++ b/drivers/staging/most/hdm-usb/hdm_usb.c
> @@ -145,7 +145,7 @@ static void wq_netinfo(struct work_struct *wq_obj);
> static inline int drci_rd_reg(struct usb_device *dev, u16 reg, u16 *buf)
> {
> int retval;
> - u16 *dma_buf = kzalloc(sizeof(u16), GFP_KERNEL);
> + __le16 *dma_buf = kzalloc(sizeof(*dma_buf), GFP_KERNEL);
> u8 req_type = USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE;
>
> if (!dma_buf)
> @@ -154,7 +154,7 @@ static inline int drci_rd_reg(struct usb_device *dev, u16 reg, u16 *buf)
> retval = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0),
> DRCI_READ_REQ, req_type,
> 0x0000,
> - reg, dma_buf, sizeof(u16), 5 * HZ);
> + reg, dma_buf, sizeof(*dma_buf), 5 * HZ);
> *buf = le16_to_cpu(*dma_buf);
> kfree(dma_buf);
>

\
 
 \ /
  Last update: 2017-01-10 10:45    [W:0.094 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site