lkml.org 
[lkml]   [2017]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 57/62] watchdog: tegra_wdt: Convert to use device managed functions
    Date
    Use device managed functions to simplify error handling, reduce
    source code size, improve readability, and reduce the likelyhood of bugs.

    The conversion was done automatically with coccinelle using the
    following semantic patches. The semantic patches and the scripts used
    to generate this commit log are available at
    https://github.com/groeck/coccinelle-patches

    - Use devm_watchdog_register_driver() to register watchdog device

    Cc: Stephen Warren <swarren@wwwdotorg.org>
    Cc: Thierry Reding <thierry.reding@gmail.com>
    Cc: Alexandre Courbot <gnurou@gmail.com>
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    ---
    drivers/watchdog/tegra_wdt.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/watchdog/tegra_wdt.c b/drivers/watchdog/tegra_wdt.c
    index 2d53c3f9394f..9403c08816e3 100644
    --- a/drivers/watchdog/tegra_wdt.c
    +++ b/drivers/watchdog/tegra_wdt.c
    @@ -226,7 +226,7 @@ static int tegra_wdt_probe(struct platform_device *pdev)

    watchdog_set_nowayout(wdd, nowayout);

    - ret = watchdog_register_device(wdd);
    + ret = devm_watchdog_register_device(&pdev->dev, wdd);
    if (ret) {
    dev_err(&pdev->dev,
    "failed to register watchdog device\n");
    @@ -248,8 +248,6 @@ static int tegra_wdt_remove(struct platform_device *pdev)

    tegra_wdt_stop(&wdt->wdd);

    - watchdog_unregister_device(&wdt->wdd);
    -
    dev_info(&pdev->dev, "removed wdt\n");

    return 0;
    --
    2.7.4
    \
     
     \ /
      Last update: 2017-01-11 03:12    [W:4.104 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site