Messages in this thread | | | Subject | Re: [PATCH] usb: dwc3-exynos fix axius clock error path to do cleanup | From | Javier Martinez Canillas <> | Date | Tue, 10 Jan 2017 21:27:50 -0300 |
| |
Hello Shuah,
Patch looks good to me, I've just one comment.
On 01/10/2017 08:05 PM, Shuah Khan wrote: > Axius clock error path returns without disabling clock and suspend clock. > Fix it to disable them before returning error. > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > --- > drivers/usb/dwc3/dwc3-exynos.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c > index 3e8407a..f7421c2 100644 > --- a/drivers/usb/dwc3/dwc3-exynos.c > +++ b/drivers/usb/dwc3/dwc3-exynos.c > @@ -136,7 +136,8 @@ static int dwc3_exynos_probe(struct platform_device *pdev) > exynos->axius_clk = devm_clk_get(dev, "usbdrd30_axius_clk"); > if (IS_ERR(exynos->axius_clk)) { > dev_err(dev, "no AXI UpScaler clk specified\n"); > - return -ENODEV; > + ret = -ENODEV; > + goto axius_clk_err; > } > clk_prepare_enable(exynos->axius_clk); > } else { > @@ -194,6 +195,7 @@ static int dwc3_exynos_probe(struct platform_device *pdev) > regulator_disable(exynos->vdd33); > err2: > clk_disable_unprepare(exynos->axius_clk); > +axius_clk_err:
This label isn't consistent with the others, I know the errN aren't great so what about changing those to meaningful names in a preparatory patch?
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
| |