Messages in this thread | | | Subject | Re: [PATCH 7/8] mmc-core: Use kcalloc() in mmc_test_alloc_mem() | From | Shawn Lin <> | Date | Tue, 10 Jan 2017 16:28:35 +0800 |
| |
On 2017/1/9 5:50, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 8 Jan 2017 21:43:12 +0100 > > * The script "checkpatch.pl" pointed information out like the following. > > WARNING: Prefer kcalloc over kzalloc with multiply > > Thus fix the affected source code place. >
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
> * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/mmc/core/mmc_test.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c > index 294d3c675734..cb4750de2720 100644 > --- a/drivers/mmc/core/mmc_test.c > +++ b/drivers/mmc/core/mmc_test.c > @@ -360,8 +360,7 @@ static struct mmc_test_mem *mmc_test_alloc_mem(unsigned long min_sz, > if (!mem) > return NULL; > > - mem->arr = kzalloc(sizeof(struct mmc_test_pages) * max_segs, > - GFP_KERNEL); > + mem->arr = kcalloc(max_segs, sizeof(*mem->arr), GFP_KERNEL); > if (!mem->arr) > goto out_free; > >
-- Best Regards Shawn Lin
| |