lkml.org 
[lkml]   [2017]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 0/2] Style fixes: open code obfuscating macros


On 10/01/17 04:06 PM, Joe Perches wrote:
> It might also be better to add and use YA
> logging macro like ndev_dbg
>
> #define ndev_dvg(ndev, fmt, ...) \
> dev_dbg(&(ndev)->ntb.pdev->dev, fmt, ##__VA_ARGS__)
>
> so that the new temporaries that are used just
> for debugging are not required.
>

I feel like that's going in the exact opposite direction from what Greg
was looking for... I think the point is to hide less of where the device
is coming from, not to create a new and different macro that hides
things in a different way.

Or, more likely, I _think_ Greg would suggest that this is showing that
the driver model isn't really being used properly. Perhaps, we should be
printing against the ntb struct device instead of the pci device so
there is no dereferencing.

Logan

\
 
 \ /
  Last update: 2017-01-11 00:35    [W:0.055 / U:5.208 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site