lkml.org 
[lkml]   [2017]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT PULL] namespace related fixes for 4.10-rc3
Al Viro <viro@ZenIV.linux.org.uk> writes:

> On Sat, Jan 07, 2017 at 06:29:52AM +0000, Al Viro wrote:
>> On Sat, Jan 07, 2017 at 06:30:05PM +1300, Eric W. Biederman wrote:
>>
>> > Eric W. Biederman (3):
>> > mnt: Protect the mountpoint hashtable with mount_lock
>> ACK
>>
>> > mnt: Tuck mounts under others instead of creating shadow/side mounts.
>>
>> NAK; you have reintroduced put_mountpoint() outside of mount lock in there
>> and you've got seriously confused umount side of the things.
>
> PS: details are in my reply (admittedly, sent only ~20 minutes
> before your pull request) to your patch. Check Message-ID
> <20170107050644.GA12074@ZenIV.linux.org.uk>

I suspect that was sent while I was composing my pull request, and the
locking around put_mountpoint I did fail to catch during my rebase. I
will finish our conversation about that before I resend that patch.

> My apologies for not getting to it yesterday (the patch was posted a couple of
> days ago, AFAICS) - I'd been off-net since Wednesday, just got back
> ;-/

You and Ram Pai had said reasonably pleasant things about a previous
version of that patch.

Eric

\
 
 \ /
  Last update: 2017-01-11 00:27    [W:0.070 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site