Messages in this thread | | | Subject | Re: [alsa-devel] [PATCH] ASoC: Intel: remove status, it is shadowing status of a higher scope | From | Pierre-Louis Bossart <> | Date | Fri, 9 Sep 2016 10:04:22 -0700 |
| |
On 9/9/16 2:09 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The second declaration of status is shadowing the status of a higher > scope. This uninitialized status results in garbage being returned > by the !x86_match_cpu(cpu_ids) || !iosf_mbi_available() return exit > path. Fix this by removing the extraneous second declaration of > status. > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Gah... thanks for correcting this, not sure how I missed it, was there a compiler warning? Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> --- > sound/soc/intel/atom/sst/sst_acpi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c > index 773acfb..4c14215 100644 > --- a/sound/soc/intel/atom/sst/sst_acpi.c > +++ b/sound/soc/intel/atom/sst/sst_acpi.c > @@ -249,7 +249,6 @@ static int is_byt_cr(struct device *dev, bool *bytcr) > { X86_VENDOR_INTEL, 6, 55 }, /* Valleyview, Bay Trail */ > {} > }; > - int status; > u32 bios_status; > > if (!x86_match_cpu(cpu_ids) || !iosf_mbi_available()) { >
| |