Messages in this thread | | | From | Kees Cook <> | Date | Thu, 8 Sep 2016 15:01:52 -0700 | Subject | Re: pstore/core: drop cmpxchg based updates |
| |
On Thu, Sep 8, 2016 at 2:32 PM, Guenter Roeck <linux@roeck-us.net> wrote: > On Wed, Aug 24, 2016 at 03:09:35PM +0200, Sebastian Andrzej Siewior wrote: >> I have here a FPGA behind PCIe which exports SRAM which I use for >> pstore. Now it seems that the FPGA no longer supports cmpxchg based >> updates and writes back 0xff…ff and returns the same. This leads to >> crash during crash rendering pstore useless. >> Since I doubt that there is much benefit from using cmpxchg() here, I am >> dropping this atomic access and use the spinlock based version. >> >> Cc: Anton Vorontsov <anton@enomsg.org> >> Cc: Colin Cross <ccross@android.com> >> Cc: Kees Cook <keescook@chromium.org> >> Cc: Tony Luck <tony.luck@intel.com> >> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> >> Tested-by: Rabin Vincent <rabinv@axis.com> > > Great, one item taken off my task list. > > As Rabin suggested, this patch is needed for at least some ARM chips, > and should be applied to stable releases.
Okay, I've annotated it now.
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Thanks!
-Kees
-- Kees Cook Nexus Security
| |