lkml.org 
[lkml]   [2016]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    Subjectlsl / lsr possible confusion in v7_flush_dcache_all
    Hi !
    While reading the v7_flush_dcache_all (arch/arm/mm/cache-v7.S), I
    stumbled upon this line:

    # r10 is the current cache level
    127: add r2, r10, r10, lsr #1 @ work out 3x current cache level

    If we want r2 to be 3 * r10, we should compute r10 + (r10 << 1), which
    is lsl, not lsr.

    I check for a recent kernel, the issue seems to still be here:
    repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
    revision: d71f058617564750261b673ea9b3352382b9cde4

    Best regards,
    Vincent Siles
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2016-09-17 09:58    [W:4.753 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site