Messages in this thread | | | From | Meng Yi <> | Subject | RE: [PATCH 3/4] drm/fsl-dcu: update all registers on flush | Date | Wed, 7 Sep 2016 08:46:32 +0000 |
| |
Hi Stefan,
Some comments below
> > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c b/drivers/gpu/drm/fsl- > dcu/fsl_dcu_drm_crtc.c > index d30b61e..62eb284 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c > @@ -27,6 +27,9 @@ static void fsl_dcu_drm_crtc_atomic_flush(struct drm_crtc > *crtc, { > struct drm_pending_vblank_event *event = crtc->state->event; > > + regmap_write(fsl_dev->regmap, > + DCU_UPDATE_MODE, DCU_UPDATE_MODE_READREG);
fsl_dev is not declared. I had added these two lines when testing the patches.
struct drm_device *dev = crtc->dev; struct fsl_dcu_drm_device *fsl_dev = dev->dev_private;
> + > if (event) { > crtc->state->event = NULL; >
Best Regards, Meng
| |