lkml.org 
[lkml]   [2016]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11 5/8] clocksource/drivers/arm_arch_timer: Simplify ACPI support code.
On Tue, 6 Sep 2016, fu.wei@linaro.org wrote:
> + if (timer_count < 0)
> + pr_err("Failed to get platform timer info, skipping.\n");

So this prints something about skipping. But then it continues as if
nothing went wrong. That's either wrong or confusing or both.

> - arch_timer_init();
> - return 0;
> + return arch_timer_init();

Thanks,

tglx

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.066 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site