lkml.org 
[lkml]   [2016]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm/atmel-hlcdc: mark atmel_hlcdc_crtc_reset() static
On Tue, 06 Sep 2016 15:43:45 +0200
Arnd Bergmann <arnd@arndb.de> wrote:

> On Tuesday, September 6, 2016 3:46:16 PM CEST Baoyou Xie wrote:
> > We get 1 warning when building kernel with W=1:
> > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c:390:6: warning: no previous prototype for 'atmel_hlcdc_crtc_reset' [-Wmissing-prototypes]
> >
> > In fact, this function is only used in the file in which it is
> > declared and don't need a declaration, but can be made static.
> > So this patch marks it 'static'.
> >
> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> >
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Actually, Thierry already posted the same patch a while ago. I just
sent a PR to Dave containing this patch.

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.037 / U:1.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site