lkml.org 
[lkml]   [2016]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 01/21] ACPI-video: Use kmalloc_array() in acpi_video_get_levels()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 5 Sep 2016 11:33:30 +0200

    A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus use the corresponding function "kmalloc_array".

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/acpi/acpi_video.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
    index c5557d0..3d39b53 100644
    --- a/drivers/acpi/acpi_video.c
    +++ b/drivers/acpi/acpi_video.c
    @@ -784,8 +784,9 @@ int acpi_video_get_levels(struct acpi_device *device,
    goto out;
    }

    - br->levels = kmalloc((obj->package.count + 2) * sizeof *(br->levels),
    - GFP_KERNEL);
    + br->levels = kmalloc_array(obj->package.count + 2,
    + sizeof(*br->levels),
    + GFP_KERNEL);
    if (!br->levels) {
    result = -ENOMEM;
    goto out_free;
    --
    2.10.0
    \
     
     \ /
      Last update: 2016-09-17 09:58    [W:5.280 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site