lkml.org 
[lkml]   [2016]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.7 073/143] of: fix reference counting in of_graph_get_endpoint_by_regs
    Date
    4.7-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Lucas Stach <l.stach@pengutronix.de>

    commit 34276bb062b8449b3b0a208c9b848a1a27920075 upstream.

    The called of_graph_get_next_endpoint() already decrements the refcount
    of the prev node, so it is wrong to do it again in the calling function.

    Use the for_each_endpoint_of_node() helper to interate through the
    endpoint OF nodes, which already does the right thing and simplifies
    the code a bit.

    Fixes: 8ccd0d0ca041
    (of: add helper for getting endpoint node of specific identifiers)
    Reported-by: David Jander <david@protonic.nl>
    Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
    Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
    Signed-off-by: Rob Herring <robh@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/of/base.c | 11 ++---------
    1 file changed, 2 insertions(+), 9 deletions(-)

    --- a/drivers/of/base.c
    +++ b/drivers/of/base.c
    @@ -2318,20 +2318,13 @@ struct device_node *of_graph_get_endpoin
    const struct device_node *parent, int port_reg, int reg)
    {
    struct of_endpoint endpoint;
    - struct device_node *node, *prev_node = NULL;
    -
    - while (1) {
    - node = of_graph_get_next_endpoint(parent, prev_node);
    - of_node_put(prev_node);
    - if (!node)
    - break;
    + struct device_node *node = NULL;

    + for_each_endpoint_of_node(parent, node) {
    of_graph_parse_endpoint(node, &endpoint);
    if (((port_reg == -1) || (endpoint.port == port_reg)) &&
    ((reg == -1) || (endpoint.id == reg)))
    return node;
    -
    - prev_node = node;
    }

    return NULL;

    \
     
     \ /
      Last update: 2016-09-17 09:58    [W:3.009 / U:0.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site