Messages in this thread | | | Date | Mon, 5 Sep 2016 09:07:16 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH v4 3/3] iio: adc: add support for Allwinner SoCs ADC |
| |
Hi,
Nitpicks ahead.
On Thu, Sep 01, 2016 at 04:05:05PM +0200, Quentin Schulz wrote: > + info->soc_specific = (struct soc_specific *)platform_get_device_id(pdev)->driver_data;
This line is still rather long. How about calling the field "data" and the structure gpadc_data?
> + > + tzd = devm_thermal_zone_of_sensor_register(pdev->dev.parent, 0, info, > + &sun4i_ts_tz_ops);
A comment on why you put the parent device structure and not the device itself like you're doing on all the other calls in that probe would be nice.
Thanks! Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |