lkml.org 
[lkml]   [2016]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ubifs: compress lines for immediate return
From
Date
Hello Richard,

Am 05.09.2016 um 08:28 schrieb Richard Weinberger:
> Heiko,
>
> On 05.09.2016 06:59, Heiko Schocher wrote:
>> fix the following code:
>>
>> -ret = expression;
>> -if (ret)
>> - return ret;
>> -return 0;
>> +return expression;
>
> "Fix"? ;-)
> What was broken?

Ok, fix is to hard spoken ... nothing broken, sorry for confusing!

> I agree that we can write the expression in a different way, but is it really worth it?

I think yes ...

> Is this part of a tree-wide cleanup?

Yes, and I thought it is worth to change this part in linux too.

bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.051 / U:1.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site