Messages in this thread | | | From | Masahiro Yamada <> | Date | Mon, 5 Sep 2016 22:26:04 +0900 | Subject | Re: [PATCH v2] ubifs: compress lines for immediate return |
| |
2016-09-05 22:18 GMT+09:00 David Oberhollenzer <david.oberhollenzer@sigma-star.at>: > On 09/05/2016 08:54 AM, Heiko Schocher wrote: >> diff --git a/fs/ubifs/budget.c b/fs/ubifs/budget.c >> index 11a11b3..48d6851 100644 >> --- a/fs/ubifs/budget.c >> +++ b/fs/ubifs/budget.c >> @@ -77,7 +77,7 @@ static void shrink_liability(struct ubifs_info *c, int nr_to_write) >> */ >> static int run_gc(struct ubifs_info *c) >> { >> - int err, lnum; >> + int lnum; >> >> /* Make some free space by garbage-collecting dirty space */ >> down_read(&c->commit_sem); >> @@ -88,10 +88,7 @@ static int run_gc(struct ubifs_info *c) >> >> /* GC freed one LEB, return it to lprops */ >> dbg_budg("GC freed LEB %d", lnum); >> - err = ubifs_return_leb(c, lnum); >> - if (err) >> - return err; >> - return 0; >> + return = ubifs_return_leb(c, lnum); >> } >> > > Apart from the other issues discussed below and in v1, I don't > believe that this _ever_ compiled successfully. >
Just in case:
It was not me who added '=' after 'return'. (I usually run build-test before sending my patches.)
-- Best Regards Masahiro Yamada
| |