lkml.org 
[lkml]   [2016]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.
From
Date
On 04/09/16 11:15, Amit Ghadge wrote:
> I will be send individual patches.
>
> I was try,
> make M=drivers/staging/comedi/
>
> No issue generated, Is there have any other option to test these changes?

You need to configure the kernel to build the drivers you are changing.

Also, please don't top-post!

>
>
> Amit G
>
> On Sun, Sep 4, 2016 at 2:05 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> On Sun, Sep 04, 2016 at 01:41:03AM +0530, Amit Ghadge wrote:
>>> Fixes checkpatch warning:
>>> WARNING: Block comments use * on subsequent lines
>>>
>>> Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid
>>> of checkpatch.pl "CHECK" output "Prefer using the BIT macro".
>>> Replace Avoid CamelCase range_0_20mA to range_0_20ma.
>>
>> That's multiple things in the same patch, and you didn't even test build
>> your change :(
>>
>> Please do better than this in the future.
>>
>> greg k-h


--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.065 / U:8.800 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site