Messages in this thread | | | Subject | Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile() | From | SF Markus Elfring <> | Date | Sun, 4 Sep 2016 07:00:22 +0200 |
| |
> Does this change improve the resulting binary?
I hope so. - I propose to give the refactorings "Reduce scope of variable" and "Extract a function" (and the corresponding consequences) another look.
> I.e. does it make it smaller or faster?
It is generally possible that a specific code generation variant will also affect the run time properties you mentioned.
> Otherwise this change is useless churn - you're making the code more > complicated, longer and harder to read for practically no benefit.
I imagine that there other reasons you could eventually accept for this use case, aren't there?
Regards, Markus
| |