Messages in this thread | | | Date | Sat, 03 Sep 2016 18:52:44 +0200 | From | Daniel Borkmann <> | Subject | Re: [PATCH 4/4] sparc: bpf_jit: Rename jump labels in bpf_jit_compile() |
| |
On 09/03/2016 06:41 PM, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 3 Sep 2016 18:14:19 +0200 > > Adjust jump labels according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
NAK, just noise.
> --- > arch/sparc/net/bpf_jit_comp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/sparc/net/bpf_jit_comp.c b/arch/sparc/net/bpf_jit_comp.c > index a6b6e29..3aa19a1 100644 > --- a/arch/sparc/net/bpf_jit_comp.c > +++ b/arch/sparc/net/bpf_jit_comp.c > @@ -761,7 +761,7 @@ cond_branch: f_offset = addrs[i + filter[i].jf]; > > default: > /* hmm, too complex filter, give up with jit compiler */ > - goto out; > + goto free_addresses; > } > ilen = (void *) prog - (void *) temp; > if (image) { > @@ -793,7 +793,7 @@ cond_branch: f_offset = addrs[i + filter[i].jf]; > if (proglen == oldproglen) { > image = module_alloc(proglen); > if (!image) > - goto out; > + goto free_addresses; > } > oldproglen = proglen; > } > @@ -806,7 +806,7 @@ cond_branch: f_offset = addrs[i + filter[i].jf]; > fp->bpf_func = (void *)image; > fp->jited = 1; > } > -out: > + free_addresses: > kfree(addrs); > return; > } >
| |