Messages in this thread | | | From | Leo Li <> | Subject | RE: [PATCH] dma/fsldma : Unmap region obtained by of_iomap | Date | Thu, 29 Sep 2016 16:57:38 +0000 |
| |
> -----Original Message----- > From: Arvind Yadav [mailto:arvind.yadav.cs@gmail.com] > Sent: Wednesday, September 28, 2016 5:45 AM > To: leoli@freescale.com; zw@zh-kernel.org; vinod.koul@intel.com > Cc: dan.j.williams@intel.com; linuxppc-dev@lists.ozlabs.org; > dmaengine@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] dma/fsldma : Unmap region obtained by of_iomap > > Free memory mapping, if probe is not successful. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
> --- > drivers/dma/fsldma.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index > 911b717..7ba8944 100644 > --- a/drivers/dma/fsldma.c > +++ b/drivers/dma/fsldma.c > @@ -1351,7 +1351,7 @@ static int fsldma_of_probe(struct platform_device > *op) > if (!fdev->regs) { > dev_err(&op->dev, "unable to ioremap registers\n"); > err = -ENOMEM; > - goto out_free_fdev; > + goto out_free; > } > > /* map the channel IRQ if it exists, but don't hookup the handler yet */ > @@ -1416,6 +1416,8 @@ static int fsldma_of_probe(struct platform_device > *op) > > out_free_fdev: > irq_dispose_mapping(fdev->irq); > + iounmap(fdev->regs); > +out_free: > kfree(fdev); > out_return: > return err; > -- > 1.7.9.5
| |