lkml.org 
[lkml]   [2016]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 037/119] be2iscsi: Fix bogus WARN_ON length check
    Date
    From: Tim Gardner <tim.gardner@canonical.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit dd29dae00d39186890a5eaa2fe4ad8768bfd41a9 upstream.

    drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
    drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
    WARN_ON(!length > 0);

    gcc version 5.2.1

    Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
    Cc: Jayamohan Kallickal <jayamohan.kallickal@avagotech.com>
    Cc: Minh Tran <minh.tran@avagotech.com>
    Cc: John Soni Jose <sony.john-n@avagotech.com>
    Cc: "James E.J. Bottomley" <JBottomley@odin.com>
    Reported-by: Joel Stanley <joel@jms.id.au>
    Reviewed-by: Manoj Kumar <manoj@linux.vnet.ibm.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Cc: Willy Tarreau <w@1wt.eu>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    drivers/scsi/be2iscsi/be_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
    index 8eeb24272154..fdff867f9d8e 100644
    --- a/drivers/scsi/be2iscsi/be_main.c
    +++ b/drivers/scsi/be2iscsi/be_main.c
    @@ -2978,7 +2978,7 @@ be_sgl_create_contiguous(void *virtual_address,
    {
    WARN_ON(!virtual_address);
    WARN_ON(!physical_address);
    - WARN_ON(!length > 0);
    + WARN_ON(!length);
    WARN_ON(!sgl);

    sgl->va = virtual_address;
    --
    2.10.0
    \
     
     \ /
      Last update: 2016-09-29 12:50    [W:3.181 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site