Messages in this thread | | | Subject | Re: [PATCH v1] mlx4: remove unused fields | From | Eric Dumazet <> | Date | Wed, 28 Sep 2016 11:19:07 -0700 |
| |
On Wed, 2016-09-28 at 11:00 -0700, David Decotigny wrote: > From: David Decotigny <decot@googlers.com> > > This also can address following UBSAN warnings: > [ 36.640343] ================================================================================ > [ 36.648772] UBSAN: Undefined behaviour in drivers/net/ethernet/mellanox/mlx4/fw.c:857:26 > [ 36.656853] shift exponent 64 is too large for 32-bit type 'int' > [ 36.663348] ================================================================================ > [ 36.671783] ================================================================================ > [ 36.680213] UBSAN: Undefined behaviour in drivers/net/ethernet/mellanox/mlx4/fw.c:861:27 > [ 36.688297] shift exponent 35 is too large for 32-bit type 'int' > [ 36.694702] ================================================================================ > > Tested: > reboot with UBSAN, no warning. > > Signed-off-by: David Decotigny <decot@googlers.com> > ---
CC: Tariq Toukan <tariqt@mellanox.com> (mlx4 maintainer)
Note this patch was cooked/tested using net-next, but can be applied to net tree, with minor fuzz.
Acked-by: Eric Dumazet <edumazet@google.com>
Thanks David.
| |