lkml.org 
[lkml]   [2016]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v2 2/4] staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts with LED namespace
On Tue, Sep 27, 2016 at 04:51:49PM -0500, Zach Brown wrote:
> Adding led support for phy causes namespace conflicts for some
> phy drivers.
>
> The rtl871 driver declared an enum for representing LED states. The enum
> contains constant LED_OFF which conflicted with declaration found in
> linux/leds.h. LED_OFF changed to LED_STATE_OFF
> In order to avoid a possible future collision LED_ON was changed to
> LED_STATE_ON as well.
>
> Signed-off-by: Zach Brown <zach.brown@ni.com>
> ---
> drivers/staging/rtl8712/rtl8712_led.c | 388 +++++++++++++++++-----------------
> 1 file changed, 194 insertions(+), 194 deletions(-)

Ick, messy. I'll be glad to take this patch now to make your life
easier in the future.

thanks,

greg k-h

\
 
 \ /
  Last update: 2016-09-28 11:28    [W:0.059 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site