Messages in this thread | | | Subject | Re: [PATCH] kcov: properly check if we are in an interrupt | From | Vegard Nossum <> | Date | Tue, 27 Sep 2016 13:22:30 +0200 |
| |
On 09/27/2016 01:20 PM, Vegard Nossum wrote: > Your patch was: > > - if (!t || in_interrupt()) > + if (!t || (preempt_count() & (HARDIRQ_MASK | SOFTIRQ_OFFSET > + | NMI_MASK))) > > But look at the definitions: > > #define irq_count() (preempt_count() & (HARDIRQ_MASK | SOFTIRQ_MASK \ > | NMI_MASK)) > #define in_interrupt() (irq_count()) > > So isn't the patch a no-op to start with?
Eh, SOFTIRQ_OFFSET vs SOFTIRQ_MASK.
I'll just go stand in the corner.
Vegard
| |