lkml.org 
[lkml]   [2016]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [Gigaset307x-common] ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure
    Date
    Hi,

    as longtime maintainer of the code in question I feel compelled to chime
    in at this point.

    On Tue, Sep 27, 2016, at 11:34, SF Markus Elfring wrote:
    > >> Will it matter here if the function "kfree" will be called for the
    > >> data structure members "bcs" and "inbuf" after a later function call
    > >> failed within the implementation of "gigaset_initcs"?
    > >
    > > My translation of this question is: could you please hold my hand while
    > > I read the code of a driver I do not use - a driver for hardware that I
    > > don't even have, and therefor cannot really test - after I submitted a
    > > patch that appears to be broken?
    >
    > I got the impression that the exception handling was incomplete in the
    > implementation of the function "gigaset_initcs".

    That impression is wrong. Careful reading of the code will confirm that.

    > Does anybody (besides me) care for improving the software situation
    > there?

    There's no urgent need for improvement. The code is stable and there's
    no demonstrated bug to be fixed.
    You could improve the coding style, but that is of secondary importance,
    and if you want to do that, as a minimum you have to make sure that you
    don't introduce new bugs.

    Thanks,
    Tilman

    --
    Tilman Schmidt
    tilman@imap.cc

    \
     
     \ /
      Last update: 2016-09-27 12:26    [W:4.140 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site