lkml.org 
[lkml]   [2016]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style
From
Date
On 09/26/2016 06:20 AM, Gonçalo Salazar wrote:
> 2016-09-26 1:53 GMT+01:00 Larry Finger <Larry.Finger@lwfinger.net>:
>> On 09/25/2016 06:00 PM, Gonçalo Salazar wrote:
>>>
>>> Fixed a block comment indentation in the rtl8712 usb_intf.c file.
>>> Made this as a first commit.
>>> Resubmitted with updated subject.
>>>
>>> Please let me know of any feedback you have.
>>
>>
>> I missed this last time, but everything above the --- line goes into the
>> permanent record. Are you sure you want all this to be there? Any chatty
>> remarks and any description of what changed in subsequent submissions should
>> be below the ---. The maintainer will see them, but they are stripped before
>> they get merged into the repo.
>>
>> Larry
>
> Made a mistake that should not be in the permanent record...
> Should I resubmit the patch? or are you able to strip it from the submission?

I am not the one that applies the patches; however, it would be unreasonable to
expect the maintainer to edit any patch. You need to submit V3.

Larry

>

\
 
 \ /
  Last update: 2016-09-26 20:14    [W:0.059 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site